Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(94): focus() modal close button on open #116

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

granttchart
Copy link
Contributor

Description

Small a11y enhancement for #94 to focus() the modal close button when opened. In addition, ensures the close button is perfectly circular.

Checklist

  • I am requesting to merge into the dev branch
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Before After
image image

@granttchart granttchart changed the base branch from dev to main November 21, 2023 16:50
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for sprightly-muffin-751ffc ready!

Name Link
🔨 Latest commit ca05a30
🔍 Latest deploy log https://app.netlify.com/sites/sprightly-muffin-751ffc/deploys/655d1408149d590008af6832
😎 Deploy Preview https://deploy-preview-116--sprightly-muffin-751ffc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for creative-quokka-61f1f5 ready!

Name Link
🔨 Latest commit ca05a30
🔍 Latest deploy log https://app.netlify.com/sites/creative-quokka-61f1f5/deploys/655d1408d071750008f13c51
😎 Deploy Preview https://deploy-preview-116--creative-quokka-61f1f5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/components/Modal.js Outdated Show resolved Hide resolved
@lauriemerrell lauriemerrell merged commit 799b957 into chihacknight:main Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants