Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added application stopped events to JDK unified logging parser #208

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

kcrimson
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #208 into develop will increase coverage by 0.04%.
The diff coverage is 84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #208      +/-   ##
=============================================
+ Coverage      69.94%   69.99%   +0.04%     
- Complexity      1479     1483       +4     
=============================================
  Files            145      145              
  Lines           8396     8429      +33     
  Branches        1374     1375       +1     
=============================================
+ Hits            5873     5900      +27     
- Misses          1948     1953       +5     
- Partials         575      576       +1
Impacted Files Coverage Δ Complexity Δ
...perf/gcviewer/imp/DataReaderUnifiedJvmLogging.java 81.68% <84%> (+1.2%) 50 <5> (+3) ⬆️
...va/com/tagtraum/perf/gcviewer/view/GCDocument.java 33.97% <0%> (-0.97%) 23% <0%> (ø)
...java/com/tagtraum/perf/gcviewer/model/GCModel.java 86.11% <0%> (+0.25%) 131% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ceac8...e06b5e6. Read the comment docs.

@kcrimson
Copy link
Author

@chewiebug how can I view Better Code Hub report?

@cmoetzing
Copy link

@chewiebug If I navigate to 'Details' of the 'Better Code Hub' it shows me this error:

Only the repository's owners and organization members (if the repository is an organization repository) can view its Better Code Hub results.

I don't know if it is a good idea to use secret metrics to make the build fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants