Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 update. #58
Python 3.12 update. #58
Changes from 46 commits
111024a
ff41dd8
a102aee
d5240fa
3a2291c
4a5cb66
12b79af
543d85f
f6e873c
40291f7
87713dd
e7e0fb6
8aaeaa3
e515cfc
c562a70
bf771c3
1ee3fd8
f5e176a
e0675ce
e61df38
041ee81
2724f91
238dda3
abdeddf
0feae9d
1018d97
04a4a72
9844b39
c164875
676caf9
dcabbcb
eb0ab77
8ce0751
42d6e8f
176a8ad
c936949
9d08ba7
f1f1615
ec8a45e
3a41156
f7a73bf
1f4ce2a
36616a8
8e372ef
4f22e7e
35f4b1c
7fe9200
0f0c21e
5bb35ca
e7cc6e0
5766411
797af65
f3a26fe
6246aae
1648d3b
7921672
e43aaa7
253a5d7
21a69bb
3cb102c
9545364
879667f
e4c1428
b46e772
bb559dd
d65c50f
3ec71bf
253e629
e783ef9
ddd58ee
955703b
1535503
2ae496a
6187a23
e4868b4
c1d74ac
c87952a
bf5f05b
ffac61a
7548eaa
ced2651
8a2f99d
a5de779
2303a25
aada621
ac6595f
e45dcd7
77ba463
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this variabl here.
I think that we can install all the packageis via
pip install -r requirements.txt
then the
requirements.txt
file will be used by the security scanners.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hhmmm… Now that you put it this way, it's obvious
pywin32
is missing fromrequirements.txt
. Unless the dev building locally uses Windows, of course!There's also
pip
itself, which is installed in a peculiar way, which differs on Windows compared to the other OS'es.Actually, lately only
psutil
is always installed in a generic way, using the the still presentPIP_LIBRARIES
env var. And this is only until #60 is fixed.So, I guess no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintaining
requirements.txt
could be fixed through https://github.com/stefanzweifel/git-auto-commit-action to automate updatingrequirements.txt
through the Windows GHA job. Of course, only after there's apywin32
wheel for Python 3.13 and the Windows build can finish successfully.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left things as is for now, as
requirements.txt
is not the same on Windows and the other platforms.To make sure it's not left behind, I've used the above GitHub action on Windows, where
pywin32
is also installed. An example of such an automatic commit: e783ef9.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also filled #62 for improving current situation.
This file was deleted.