Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to sync in auth handlers #973

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

lucagobbi
Copy link
Collaborator

Description

Removed async stuff from BaseAuthHandler and other methods that were not using real async stuff. This is a breaking change since async custom auth handlers implementation needs to migrate to sync one.

Will update docs and blog after merging it in main.

Related to issue #958

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@valentimarco
Copy link
Collaborator

https://tenor.com/view/rip-juice-cry-cat-kitten-tears-gif-15751834

@pieroit
Copy link
Member

pieroit commented Nov 18, 2024

@lucagobbi thanks!
@valentimarco I still do not understand why async is so cool and why we should deal with the complexity, while we run already in the damn threadpool XD

@pieroit pieroit merged commit 4e74923 into cheshire-cat-ai:develop Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants