Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle REXML exception #528

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Handle REXML exception #528

merged 1 commit into from
Aug 12, 2024

Conversation

tpowell-progress
Copy link
Contributor

@tpowell-progress tpowell-progress commented Aug 9, 2024

Description

ReXML 3.3.2 broke the knife-windows functionality by adding a REXML::ParseException raise

Handle that exception and return an error message as before.

Supercedes #527, leaving #526 with the old behavior and a ReXML pin to v3.2.6

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Thomas Powell <[email protected]>
@tpowell-progress tpowell-progress requested review from a team as code owners August 9, 2024 16:21

@tpowell-progress tpowell-progress merged commit dd1de21 into main Aug 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants