Almalinux update to v9.5 #1586
Almalinux update to v9.5 #1586
Conversation
…king builds Signed-off-by: Phillip Ross <[email protected]>
Signed-off-by: Phillip Ross <[email protected]>
There was a problem hiding this comment.
The changes to the url paths for almalinux 8 aren't needed. For almalinux 9 please only update the iso version from 9.4 to 9.5. Adding .5 to the version number in the path is not needed. This is just to simplify changes and minimize future potential to forget to increment both items in the url on future releases.
|
Apologies, I'd forgotten to actually explain the reasoning behind the change 😬 There is a problem in that the URLs without the minor versions are not stable. When they release a new version, they change the underlying resources the URL refers to and the resource located at the iso_checksum URL no longer points to the resource that iso_url points to. This breaks the build until someone manually edits the pkrvars and takes it through the PR workflow. By adding the minor versions to both the iso_url and iso_checksum properties the builds remain stable as the resources do not change out from under the URLs even when a new version is released. When a new release occurs, the pkrvars file needs to be changed to refer to the new versions, but the minor version is already specified explicitly in multiple vars anyway and needs to be changed in multiple places. Necessitating a 3rd change in an adjacent variable seems a worthy tradeoff to prevent the builds from breaking when a new version is released. Wouldn't you agree? |
|
I can see your point and makes sense. My thought was more on breakage indicating a new version and thus we should update for that new version otherwise it's hard to monitor and can take a while before someone notices the new version is released and update this. As is the latter is also still the case too so I can see both ways. Do you use these templates and need more stability from random breakage due to new version release or would you rather have the updated version sooner? |
|
I've also thought about making local variables in each for version number and then assigning it in os_version variable and string interpolation in the url so you only need to update the version once in the local variable. |
|
Given that I'm already seeing a thumbs down on my comment, I suspect other folks are relying on the breakage to signal a new version being available, though there's probably a more robust way of getting this same signal 😁 I'm happy to modify the alma/rocky PRs I opened to revert back to using the URLs that do not contain the minor versions as I myself already understand the issue and work around it when needed, but I was thinking more about users who may not already be aware of the checksum URL changing. If indeed some local var assignments were implemented to drive everything from the os_version variable, that would probably be the cleaner way to go about forming these URLs, keeping the checksum resource always pointing to the correct iso resource, etc. 👍 |
|
currently I've been very busy with my real job and diablo 4 expansion that was released. But i'm hoping to get back to working on this project with more updates for the automated pipeline builds and such at the end of the year early next year. The variable thing then I can work on at that time. |
|
curious on thoughts of 1 file with all local variables for each defined or in each template file defining the local variable. first has ease of 1 file to update for several OS version upgrades. The latter makes it easier to read when looking at template settings which version is in use vs looking for the value in another file. I'm leaning toward the latter. |
…indicators that new versions are available. Signed-off-by: Phillip Ross <[email protected]>
|
|
Regarding the decision of how to organize the local vars, I tend to go the later route on bigger projects. The ease of having them centralized in a single file seems to be a diminishing benefit as the project grows, and this project is already fairly sizable (and growing). |
|
I agree, thanks for the input. |
Description
AlmaLinux9 update to v9.5
Types of changes