Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cs components to access pg password from secrets #8723

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jashaik
Copy link
Contributor

@jashaik jashaik commented Dec 27, 2024

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

@jashaik jashaik changed the base branch from CHEF-5668 to main December 27, 2024 07:57
@jashaik
Copy link
Contributor Author

jashaik commented Dec 27, 2024

Copy link

netlify bot commented Dec 27, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit a31d08f
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6774e1448b3c7e000885771c

SanjuPal01 and others added 7 commits December 31, 2024 21:13
* Storing password in secret helper

Signed-off-by: β€œSanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: β€œSanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: β€œSanjuPal01” <[email protected]>

---------

Signed-off-by: β€œSanjuPal01” <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
Signed-off-by: jan shahid shaik <[email protected]>
@jashaik jashaik force-pushed the shahid/final-pg-pass-fix branch 2 times, most recently from 9755708 to ea533d3 Compare January 1, 2025 06:29
Signed-off-by: jan shahid shaik <[email protected]>

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
0.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants