[CHEF-11758] Add support for config verification of backup in HA restore command #8661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
rensycthomas
changed the title
rensycthomas
force-pushed
the
rt/CHEF-11758_verify_restore_config
branch
2 times, most recently
from
220baac to
b9d365f
Compare
Comment on lines
1521
to
1527
| if osSnapshot.Es6Compliance.Type == backupLocation && osSnapshot.Es6Erchef.Type == backupLocation && osSnapshot.Es6EventFeed.Type == backupLocation && osSnapshot.Es6Ingest.Type == backupLocation { | ||
| complianceServicePath = getSnapshotPathDetails(osSnapshot.Es6Compliance.Settings.Location) | ||
| erchefServicePath = getSnapshotPathDetails(osSnapshot.Es6Erchef.Settings.Location) | ||
| eventFeedServicePath = getSnapshotPathDetails(osSnapshot.Es6EventFeed.Settings.Location) | ||
| ingestServicePath = getSnapshotPathDetails(osSnapshot.Es6Ingest.Settings.Location) | ||
| if complianceServicePath == erchefServicePath && erchefServicePath == eventFeedServicePath && erchefServicePath == ingestServicePath { | ||
| allowRestore = true | ||
| snapshotEs6ServicePath = complianceServicePath | ||
| } | ||
| } else { | ||
| err := fmt.Errorf("discrepancy in the backup types. Backup path of all indices should be %s. Refer `https://docs.chef.io/automate/ha_backup_restore_file_system/#troubleshooting` to do a clean up of the snapshot repo", backupLocation) |
There was a problem hiding this comment.
This piece of code is repeated and probably can be made common in the conditions
| } | ||
|
|
||
| func getSnapshotPathDetails(snapshotPath string) string { | ||
| parts := strings.Split(snapshotPath, "/automate-elasticsearch-data") |
There was a problem hiding this comment.
please handle the situation here if lets say parts length is zero
| path := "" | ||
| switch backupLocation { | ||
| case "fs": | ||
| if ele.Global.V1.External.Opensearch.Backup.Fs != nil && |
There was a problem hiding this comment.
can you handle here and below conditions if ele.Global.V1.External and ele.Global.V1.External.Opensearch and ele.Global.V1.External.Opensearch.Backup is not nil
Signed-off-by: Rensy Thomas <[email protected]>
Signed-off-by: Rensy Thomas <[email protected]>
rensycthomas
force-pushed
the
rt/CHEF-11758_verify_restore_config
branch
from
522b500 to
6c05d6f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description:
Add support for config verification of backup in HA restore command
Jira ID - https://progresssoftware.atlassian.net/browse/CHEF-11758
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
Error message when backup path in automate node does not match with the backup path configured in opensearch node
Error message when backup path in automate node does not match with the indices of snapshots
Error message when indices of all the snapshots are not the same
Success message
