Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated --without flag with bundle config #88

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jayashrig158
Copy link

Replacing --without flag with bundle config to get rid of bundler deprecated warning :

[DEPRECATED] The --without flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use bundle config set without 'development doc', and stop using this flag

Signed-off-by: jayashri garud [email protected]

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@jayashrig158 jayashrig158 self-assigned this Aug 12, 2021
@jayashrig158 jayashrig158 requested a review from tduffield August 12, 2021 13:19
@@ -2,7 +2,8 @@ steps:

- label: run-lint-and-specs-ruby-2.5
command:
- bundle install --jobs=7 --retry=3 --without docs debug
- bundle config set docs debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing without here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. Adding it.

@jayashrig158 jayashrig158 requested a review from tduffield August 13, 2021 04:31
@jayashrig158 jayashrig158 force-pushed the bundler_deprecated_warning branch from 4d90668 to 850767b Compare August 16, 2021 04:42
Signed-off-by: jayashri garud <[email protected]>
.expeditor/verify.pipeline.yml Outdated Show resolved Hide resolved
@tas50
Copy link
Contributor

tas50 commented Feb 1, 2022

@jayashrig158 You can just remove Ruby 2.5 testing here and add Ruby 3 instead

@jayashrig158 jayashrig158 requested review from tas50 and jeremiahsnapp and removed request for tduffield February 2, 2022 07:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants