cr: Task CapAmb support #2554
Open
cr: Task CapAmb support #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianreber
reviewed
Dec 19, 2024
images/creds.proto
Outdated
| @@ -16,13 +16,14 @@ message creds_entry { | |||
| repeated uint32 cap_prm = 10; | |||
| repeated uint32 cap_eff = 11; | |||
| repeated uint32 cap_bnd = 12; | |||
| repeated uint32 cap_amb = 13; | |||
There was a problem hiding this comment.
You cannot change protobuf IDs. That breaks backwards compatibility. Always add additional fields at the end.
|
Take a look at the CI failures. Looks like your proposed change breaks a couple of our tests. They should not break. |
Signed-off-by: Liu Chao <[email protected]>
Fixed. The rest tests do not seem to be related to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
criu only dump and restore Ing, Prm, Eff, Bnd. Add the process of dumping and restoring the CapAmb by referring to the existing implementation.