Create directories with 700 and not 644 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 11 11
Lines 1442 1442
=======================================
Hits 1102 1102
Misses 266 266
Partials 74 74 ☔ View full report in Codecov by Sentry. |
adrianreber
force-pushed
the
2024-12-14-755
branch
3 times, most recently
from
9281ecc to
5666a4c
Compare
checkpointctl was creating directories with 644 which broke usage when running as non-root as checkpointctl was not able to access the directories it created itself. Switching to 700 fixes it. This comes with a test to verify that checkpointctl works as non-root. Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2024-12-14-755
branch
from
5666a4c to
da73a77
Compare
adrianreber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkpointctl was creating directories with 644 which broke usage when running as non-root as checkpointctl was not able to access the directories it created itself. Switching to 700 fixes it.
This comes with a test to verify that checkpointctl works as non-root.
Fixes: #153