Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example of generating credentials from standard map #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

realgenekim
Copy link

Thank you for this wonderful library!

I didn't want to set environment variables, instead wanting to generate credentials from inside REPL. Enclosed is a small addition to README.md that shows an example that generates credentials from a standard map. I think other people might find this valuable?

Showing example that generates credentials from a standard map, instead of reading in from environment variable. Thank you!
@chbrown
Copy link
Owner

chbrown commented Sep 18, 2019

Thanks for your kind words & interest in improving this library! Good idea with the additional example! I have two concerns, after which I'd be happy to merge it:

  1. I've fielded a couple issues, I forget whether for this library or for twitter-api, of users coming up against various "bugs" because there's a lot of stuff that Twitter's API only supports when using user authentication. So the example should be first and foremost to create user credentials, and then — maybe as an aside or "pro-tip" — a note about preparing app credentials.
  2. The examples keys/secrets should look more like actual values. Obfuscated, of course, but it's helpful to know, for example, where to copy & paste your app key vs. access token, which is easy to distinguish if the (obfuscated) examples look like the real values, since the app key is quite a bit shorter than the user token. Feel free to reuse the example values from the snippet in the Testing section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants