Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress.yaml to use v3 kube version check syntax #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wattsap
Copy link

@wattsap wattsap commented Jun 9, 2023

With Helm 3.x, .Capabilities.KubeVersion.GitVersion is deprecated (see https://github.com/helm/helm/blob/master/pkg/chartutil/capabilities.go#L60). To avert future breakage, the chart should use .Capabilities.KubeVersion.Version in ingress.yaml when selecting which kubernetes version to pick the apiVersion for the ingress.

@cbuto
Copy link
Collaborator

cbuto commented Jun 20, 2023

thanks @wattsap, LGTM!

we'll just need to rebase with main and bump the chart version to 3.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants