Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string name in service port: & allow service: name override #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cpboyd
Copy link

@cpboyd cpboyd commented Feb 3, 2023

Fixes #43

Example below uses service: ssl-redirect with port: use-annotation.
In the current helm release, this doesn't work for two reasons:

  1. service.servicename: helm supersedes the individual service names, even when they're specified.
  2. No support for port.name & string port values.
service:
  servicename: helm

  ## Chartmuseum Ingress hostnames
  ## Must be provided if Ingress is enabled
  hosts:
    - name: helm.example.com
      path: /*
      service: helm

      ## Set this to true in order to enable TLS on the ingress record
      tls: false

  extraPaths:
    - path: /*
      service: ssl-redirect
      port: use-annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress ServiceBackendPort: "use-annotation" got "string", expected "integer" #581
1 participant