-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: renameKey
#2627
Feature: renameKey
#2627
Conversation
Can I get your review @char0n ? |
Thanks for the PR. I'm on it. ETA - today, tommor0w |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Please have a look at my code review comments.
…t into refactor/rename-key * 'refactor/rename-key' of github.com:nolleto/ramda-adjunct: (45 commits) chore(deps-dev): bump conventional-changelog-cli from 2.2.2 to 3.0.0 (char0n#2650) chore(deps-dev): bump @typescript-eslint/parser from 5.60.0 to 5.60.1 (char0n#2671) chore(deps-dev): bump @commitlint/config-conventional (char0n#2672) chore(deps-dev): bump @typescript-eslint/eslint-plugin (char0n#2670) chore(deps-dev): bump @commitlint/cli from 17.6.5 to 17.6.6 (char0n#2669) chore(deps-dev): bump glob from 10.2.7 to 10.3.0 (char0n#2668) chore(deps-dev): bump webpack from 5.87.0 to 5.88.0 (char0n#2667) chore(deps-dev): bump sinon from 15.1.2 to 15.2.0 (char0n#2666) chore(deps-dev): bump @typescript-eslint/eslint-plugin (char0n#2665) chore(deps-dev): bump @typescript-eslint/parser from 5.59.11 to 5.60.0 (char0n#2664) chore(deps-dev): bump eslint from 8.42.0 to 8.43.0 (char0n#2663) chore(deps-dev): bump webpack from 5.86.0 to 5.87.0 (char0n#2662) chore(deps-dev): bump @babel/core from 7.22.1 to 7.22.5 (char0n#2656) chore(deps-dev): bump @typescript-eslint/parser from 5.59.9 to 5.59.11 (char0n#2660) chore(deps-dev): bump @babel/cli from 7.21.5 to 7.22.5 (char0n#2657) chore(deps-dev): bump core-js from 3.30.2 to 3.31.0 (char0n#2661) chore(deps-dev): bump sinon from 15.1.0 to 15.1.2 (char0n#2658) chore(deps-dev): bump @typescript-eslint/eslint-plugin (char0n#2659) chore(deps-dev): bump @babel/plugin-transform-modules-commonjs (char0n#2655) chore(deps-dev): bump @babel/preset-env from 7.22.4 to 7.22.5 (char0n#2654) ...
@char0n can I get another review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks a lot
Pull request template
Add
renameKey
function:Issue: #1227