Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #139 Redis & EventHub #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xpdable
Copy link
Contributor

@xpdable xpdable commented Sep 5, 2022

No description provided.

@Lawouach
Copy link
Contributor

Lawouach commented Sep 5, 2022

Hello @xpdable

Thanks. It would probably better to not mix a PR for both aspects: adding redis and changing again the client auth.

Also using eval will indeed be a nogo. Better use the importlib mechanism?

@xpdable
Copy link
Contributor Author

xpdable commented Sep 5, 2022

I see no impact if I tell the return type of the init method.

and OK, will think about the init refactory after redis and eventhub PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants