-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for negative values #49
Support for negative values #49
Conversation
@krzysztof-zych |
Thanks a lot for your pull request. Negative values can be complicated. The first input value is invalid, which was generated by overwriting contents in selection. In one line of code, you used Please feel free to continue working on this pull request. Thanks again. |
Hi @changhuixu The first input is definitely invalid and I believe I fixed it in the last commit. The problem was related to the I do not want to use another flag to explicit say that this particular input has support for negative values, because Thanks again and looking for your comment. |
Hi @changhuixu Thanks. |
Could you pull the latest master branch? I updated an e2e test in order to prevent from breaking some existing applications. |
Merge pull request from changhuixu/master
# Conflicts: # projects/uiowa/digit-only/src/lib/digit-only.directive.ts
…ure will not break existing applications
merges pull #49, thanks @krzysztof-zych
I have published a new version v3.1.0. Please give it a try. Currently, the Travis CI is not working due to the transition their domain names or due to other reasons. Thus the demo site is not up-to-date. I am thinking of finding a new way for CI/CD. |
I also changed the default branch name to "main". FYI. |
CI/CD is working now. FYI. The demo site is updated. |
Hi! |
@patrykdawid |
Quick autocorrect :) Thanks! |
This PR will resolve #34 and add support for negative values
User can specify the negative sign with
negativeSign
input value (default-
).