Internal: Implement LP progress reminder functionality from Chamilo 1.11.x in Chamilo 2 - refs BT#22063 #5832

christianbeeznest · 2024-10-01T02:57:13Z

No description provided.

….11.x in Chamilo 2 - refs BT#22063

…param - refs BT#22063

… BT#22063

…ogress reminder - refs BT#22063

codeclimate · 2024-10-09T21:07:42Z

src/CoreBundle/Command/LpProgressReminderCommand.php

@@ -0,0 +1,256 @@
+<?php
+
+declare(strict_types=1);


Add a single space around assignment operators

codeclimate · 2024-10-09T21:07:43Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Output\OutputInterface;
+
+class LpProgressReminderCommand extends Command


Missing class doc comment

codeclimate · 2024-10-09T21:07:43Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+
+    private const NUMBER_OF_DAYS_TO_RESEND_NOTIFICATION = 3;
+
+    public function __construct(


Missing function doc comment

codeclimate · 2024-10-09T21:07:43Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+    private const NUMBER_OF_DAYS_TO_RESEND_NOTIFICATION = 3;
+
+    public function __construct(
+        private CourseRepository $courseRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-10-09T21:07:43Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+
+    public function __construct(
+        private CourseRepository $courseRepository,
+        private CourseRelUserRepository $courseRelUserRepository,


Line indented incorrectly; expected 4 spaces, found 8

…rt - refs BT#22063

codeclimate · 2024-11-06T22:38:48Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+    private const NUMBER_OF_DAYS_TO_RESEND_NOTIFICATION = 3;
+
+    public function __construct(
+        private readonly CourseRepository $courseRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-06T22:38:49Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+
+    public function __construct(
+        private readonly CourseRepository $courseRepository,
+        private readonly CourseRelUserRepository $courseRelUserRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-06T22:38:49Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+    public function __construct(
+        private readonly CourseRepository $courseRepository,
+        private readonly CourseRelUserRepository $courseRelUserRepository,
+        private readonly SessionRelCourseRelUserRepository $sessionRelCourseRelUserRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-06T22:38:49Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly CourseRepository $courseRepository,
+        private readonly CourseRelUserRepository $courseRelUserRepository,
+        private readonly SessionRelCourseRelUserRepository $sessionRelCourseRelUserRepository,
+        private readonly ExtraFieldValuesRepository $extraFieldValuesRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-06T22:38:49Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly CourseRelUserRepository $courseRelUserRepository,
+        private readonly SessionRelCourseRelUserRepository $sessionRelCourseRelUserRepository,
+        private readonly ExtraFieldValuesRepository $extraFieldValuesRepository,
+        private readonly TrackEDefaultRepository $trackEDefaultRepository,


Line indented incorrectly; expected 4 spaces, found 8

…s BT#22063

…T#22063

codeclimate · 2024-11-21T02:46:34Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly SessionRelCourseRelUserRepository $sessionRelCourseRelUserRepository,
+        private readonly ExtraFieldValuesRepository $extraFieldValuesRepository,
+        private readonly TrackEDefaultRepository $trackEDefaultRepository,
+        private readonly UserRepository $userRepository,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-21T02:46:34Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly ExtraFieldValuesRepository $extraFieldValuesRepository,
+        private readonly TrackEDefaultRepository $trackEDefaultRepository,
+        private readonly UserRepository $userRepository,
+        private readonly Environment $twig,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-21T02:46:34Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly TrackEDefaultRepository $trackEDefaultRepository,
+        private readonly UserRepository $userRepository,
+        private readonly Environment $twig,
+        private readonly TranslatorInterface $translator,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-21T02:46:34Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly UserRepository $userRepository,
+        private readonly Environment $twig,
+        private readonly TranslatorInterface $translator,
+        private readonly MessageHelper $messageHelper,


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-21T02:46:34Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        private readonly Environment $twig,
+        private readonly TranslatorInterface $translator,
+        private readonly MessageHelper $messageHelper,
+        private readonly UrlGeneratorInterface $urlGenerator


Line indented incorrectly; expected 4 spaces, found 8

codeclimate · 2024-11-22T17:34:18Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+
+        if (empty($lpItems)) {
+            $output->writeln('No learning paths with days for completion found.');
+            return Command::SUCCESS;


Missing blank line before return statement

codeclimate · 2024-11-22T17:34:18Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+        }
+
+        $output->writeln('LP progress reminder process finished.');
+        return Command::SUCCESS;


Missing blank line before return statement

codeclimate · 2024-11-22T17:34:18Z

src/CoreBundle/Command/LpProgressReminderCommand.php

+            if ($debugMode) {
+                echo "No registration date found for user $userId in course $courseId (session ID: $sessionId).\n";
+            }
+            return;


Missing blank line before return statement

codeclimate · 2024-11-22T17:34:18Z

src/CoreBundle/Entity/CourseRelUser.php

-#[ORM\Index(name: 'course_rel_user_user_id', columns: ['id', 'user_id'])]
-#[ORM\Index(name: 'course_rel_user_c_id_user_id', columns: ['id', 'c_id', 'user_id'])]
-#[ORM\Entity]
+#[ORM\Index(columns: ['id', 'user_id'], name: 'course_rel_user_user_id')]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T17:34:18Z

src/CoreBundle/Entity/CourseRelUser.php

-#[ORM\Index(name: 'course_rel_user_c_id_user_id', columns: ['id', 'c_id', 'user_id'])]
-#[ORM\Entity]
+#[ORM\Index(columns: ['id', 'user_id'], name: 'course_rel_user_user_id')]
+#[ORM\Index(columns: ['id', 'c_id', 'user_id'], name: 'course_rel_user_c_id_user_id')]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

…refs BT#22063

codeclimate · 2024-11-22T18:39:40Z

src/CoreBundle/Entity/CourseRelUser.php

-#[ORM\Entity]
+#[ORM\Index(columns: ['id', 'user_id'], name: 'course_rel_user_user_id')]
+#[ORM\Index(columns: ['id', 'c_id', 'user_id'], name: 'course_rel_user_c_id_user_id')]
+#[ORM\Entity(repositoryClass: CourseRelUserRepository::class)]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T18:39:40Z

src/CoreBundle/Entity/SessionRelCourseRelUser.php

@@ -32,7 +33,7 @@
 #[ORM\Index(columns: ['user_id'], name: 'idx_session_rel_course_rel_user_id_user')]
 #[ORM\Index(columns: ['c_id'], name: 'idx_session_rel_course_rel_user_course_id')]
 #[ORM\UniqueConstraint(name: 'course_session_unique', columns: ['session_id', 'c_id', 'user_id', 'status'])]
-#[ORM\Entity]
+#[ORM\Entity(repositoryClass: SessionRelCourseRelUserRepository::class)]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T18:39:40Z

src/CoreBundle/Entity/TrackEDefault.php

-#[ORM\Index(name: 'session', columns: ['session_id'])]
-#[ORM\Index(name: 'idx_default_user_id', columns: ['default_user_id'])]
-#[ORM\Entity]
+#[ORM\Index(columns: ['c_id'], name: 'course')]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T18:39:40Z

src/CoreBundle/Entity/TrackEDefault.php

-#[ORM\Index(name: 'idx_default_user_id', columns: ['default_user_id'])]
-#[ORM\Entity]
+#[ORM\Index(columns: ['c_id'], name: 'course')]
+#[ORM\Index(columns: ['session_id'], name: 'session')]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T18:39:40Z

src/CoreBundle/Entity/TrackEDefault.php

-#[ORM\Entity]
+#[ORM\Index(columns: ['c_id'], name: 'course')]
+#[ORM\Index(columns: ['session_id'], name: 'session')]
+#[ORM\Index(columns: ['default_user_id'], name: 'idx_default_user_id')]


Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

codeclimate · 2024-11-22T18:39:42Z

Code Climate has analyzed commit a3e1121 and detected 42 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	33
Clarity	7
Complexity	2

View more on Code Climate.

christianbeeznest added 5 commits September 30, 2024 21:56

Internal: Implement LP progress reminder functionality from Chamilo 1…

4124636

….11.x in Chamilo 2 - refs BT#22063

Internal: Fix LP progress reminder query and add resend notification …

c059b8b

…param - refs BT#22063

Internal: Fix issue retrieving users for LP progress reminders - refs…

0f295bf

… BT#22063

Internal: Fix issue with retrieving course registration date in LP pr…

df16082

…ogress reminder - refs BT#22063

Internal: Improve query to get users in session - refs BT#22063

d8a0bbc

codeclimate bot reviewed Oct 9, 2024

View reviewed changes

christianbeeznest added 2 commits November 6, 2024 15:49

Merge remote-tracking branch 'upstream/master' into matra-22063

8689fe3

Internal: Fix course-specific LP reminders with Chamilo message suppo…

3513506

…rt - refs BT#22063

codeclimate bot reviewed Nov 6, 2024

View reviewed changes

christianbeeznest added 6 commits November 12, 2024 00:27

Fix parameter binding issue in LP progress reminder notifications

96473a8

Internal: Add session course users query with LP progress check - ref…

c8d184e

…s BT#22063

Internal: Fix reminder logic to include users with null lpId - refs B…

16c1312

…T#22063

Internal: Fix query to correctly list courses for lessons- refs BT#22063

28b6563

Internal: Improve partial lp reminder process - refs BT#22063

60c30bf

Internal: Improve lp reminder registration dates - refs BT#22063

9903e40

codeclimate bot reviewed Nov 21, 2024

View reviewed changes

christianbeeznest added 2 commits November 22, 2024 12:01

git commit -am "Resolved merge conflicts with upstream/master"

5e7552a

Internal: Fix conflicts with last changes with master.

77db84a

codeclimate bot reviewed Nov 22, 2024

View reviewed changes

Internal: Fix reminder logic to ensure correct interval validation - …

a3e1121

…refs BT#22063

codeclimate bot reviewed Nov 22, 2024

View reviewed changes

NicoDucou merged commit 5a6b213 into chamilo:master Nov 25, 2024
2 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal: Implement LP progress reminder functionality from Chamilo 1.11.x in Chamilo 2 - refs BT#22063 #5832

Internal: Implement LP progress reminder functionality from Chamilo 1.11.x in Chamilo 2 - refs BT#22063 #5832

christianbeeznest commented Oct 1, 2024

codeclimate bot Oct 9, 2024

codeclimate bot Oct 9, 2024

codeclimate bot Oct 9, 2024

codeclimate bot Oct 9, 2024

codeclimate bot Oct 9, 2024

codeclimate bot Nov 6, 2024

codeclimate bot Nov 6, 2024

codeclimate bot Nov 6, 2024

codeclimate bot Nov 6, 2024

codeclimate bot Nov 6, 2024

codeclimate bot Nov 21, 2024

codeclimate bot Nov 21, 2024

codeclimate bot Nov 21, 2024

codeclimate bot Nov 21, 2024

codeclimate bot Nov 21, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot Nov 22, 2024

codeclimate bot commented Nov 22, 2024


		private const NUMBER_OF_DAYS_TO_RESEND_NOTIFICATION = 3;

		public function __construct(

		@@ -0,0 +1,256 @@
		<?php

		declare(strict_types=1);

Internal: Implement LP progress reminder functionality from Chamilo 1.11.x in Chamilo 2 - refs BT#22063 #5832

Internal: Implement LP progress reminder functionality from Chamilo 1.11.x in Chamilo 2 - refs BT#22063 #5832

Conversation

christianbeeznest commented Oct 1, 2024

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

codeclimate bot Oct 9, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 6, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 6, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 6, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 6, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 6, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 21, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 21, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 21, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 21, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 21, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot Nov 22, 2024

Choose a reason for hiding this comment

codeclimate bot commented Nov 22, 2024