Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports - Improvements on message tracking #5237

Open
wants to merge 3 commits into
base: 1.11.x
Choose a base branch
from

Conversation

juancp-contidosdixitais

Currently, tracking messages from the user report would only indicate cases when the user receives a message, not when the user sends a message, since it is assumed by default that a sent message will be answered, but this is not always the case. If we want to fully track, we must include those sent messages.

image

We created a new method (getMessageExchangeWithUser) in main/inc/lib/message.lib.php to obtain both the users from whom they have received messages and to whom they have sent messages and we modified the loading of this data in main/mySpace/myStudents.php.

On the other hand, a bug was identified where the message load is duplicated:

if ($filterMessages) {
$users = MessageManager::getUsersThatHadConversationWithUser($student_id, $coachAccessStartDate, $coachAccessEndDate);
} else {
$users = MessageManager::getUsersThatHadConversationWithUser($student_id);
}
$users = MessageManager::getUsersThatHadConversationWithUser($student_id);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants