Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various #405

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Various #405

wants to merge 12 commits into from

Conversation

Jopyth
Copy link
Contributor

@Jopyth Jopyth commented Aug 28, 2017

This PR depends on cginternals/qmltoolbox#31.

  • Introduces internal stages (stages existing only in the UI, not in the actual pipeline)
  • The former preview item was converted to an internal PreviewStage
  • The preview item currently can be connected to slots of type globjects::texture and gloperate::ColorRenderTarget with type UserDefinedFBOAttachment
  • Added: information on required slots and feedback connections
  • Fixed: changing the pipeline through the UI also updates the editor correctly

Bugged:

  • Preview stages have wrong dimensions/data in the new "external" window mode, however this would often be used with a second display, and the preview stages might not be needed in that case anyway, therefore they are currently hidden in "external" mode

Missing:

  • It would be nice to automatically connect the (first) PreviewStage to the same output which is connected to the ColorOut slot of the a pipeline.
  • Support other RenderTargets and types of render targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant