Add support for `download` function in web #2230

mbfakourii · 2024-06-02T14:38:07Z

New Pull Request Checklist

I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I'm adding
I have updated the documentation (if necessary)
I have run the tests without failures
I have updated the CHANGELOG.md in the corresponding package

Additional context and info

In this PR, download support was added to dio with the help of Blob files.

Note: There is no need to send savePath on the web and it can be empty.

kuhnroyal · 2024-06-02T15:27:52Z

This looks interesting, thanks! I read about createObjectUrlFromBlob just the other day and thought the same.

We will need some tests and and likely an example.

kuhnroyal

Probably missing some error handling.

dio/lib/src/dio/dio_for_browser.dart

AlexV525

Please write up a general idea of what behavior/standard it follows.

dio/lib/src/dio/dio_for_browser.dart

mbfakourii · 2024-06-03T12:22:01Z

@kuhnroyal @ueman @AlexV525

By further examining the web request, I realized that we use arraybuffer when requesting the web. XMLHttpRequest supports blob. I made a change in the implementation

The problem of high memory is solved.

thank you for checking again

github-actions · 2024-06-04T01:48:59Z

Code Coverage Report: Only Changed Files listed

Package	Base Coverage	New Coverage	Difference
dio/lib/src/adapters/browser_adapter.dart	🟠 75%	🟠 73.25%	🔴 -1.75%
dio/lib/src/dio/dio_for_browser.dart	🟠 57.14%	🟠 50%	🔴 -7.14%
plugins/http2_adapter/lib/src/connection_manager_imp.dart	🟠 60.47%	🟢 79.84%	🟢 19.37%
Overall Coverage	🟢 80.48%	🟢 81.31%	🟢 0.83%

Minimum allowed coverage is 0%, this run produced 81.31%

AlexV525

Still need some tests and examples here... 🛎️

dio/lib/src/options.dart

dio/lib/src/dio/dio_for_browser.dart

dio/lib/src/adapters/browser_adapter.dart

AlexV525 · 2024-06-18T06:48:31Z

Could you move on with the new structure of the code and add tests?

# Conflicts: # dio/lib/src/adapters/browser_adapter.dart # dio/lib/src/dio/dio_for_browser.dart

mbfakourii · 2024-06-18T11:13:20Z

Could you move on with the new structure of the code and add tests?

changes are applied.

thank you for checking again

AlexV525

Tests are still lacking.

AlexV525 · 2024-06-19T02:28:15Z

dio/lib/src/options.dart

+  /// Get blob url.
+  /// Only work in web.


The description seems to lack explanation.

I made changes to the description

AlexV525 · 2024-06-19T02:32:59Z

plugins/web_adapter/lib/src/html/adapter.dart

+      if (options.responseType == ResponseType.blobUrl) {
+        completer.complete(
+          ResponseBody.fromString(
+            Url.createObjectUrl(xhr.response),


Could you reuse other fields by constructing the ResponseBody with the unnamed constructor?

The ResponseBody with the unnamed constructor requires steam, we have a url string !

dio/lib/src/dio/dio_for_browser.dart

mbfakourii · 2024-07-08T05:26:05Z

changes are applied.

thank you for checking again

AlexV525 · 2024-07-26T01:24:17Z

Please add tests.

mbfakourii · 2024-09-03T11:20:28Z

Please add tests.

I tried to add the test, but I get the following error

PS C:\Users\aaa\bbb\dio\plugins\web_adapter> flutter test
Error on line 10, column 3 of dart_test.yaml: Unknown platform "chrome".
   ╷
10 │   chrome:
   │   ^^^^^^
   ╵

or

PS C:\Users\aaa\bbb\dio\plugins\web_adapter\test> flutter test .\browser_test.dart
Changing current working directory to: C:\Users\aaa\bbb\dio\plugins\web_adapter
Error on line 10, column 3 of dart_test.yaml: Unknown platform "chrome".
   ╷
10 │   chrome:
   │   ^^^^^^
   ╵

And I commented the contents of the "dart_test.yaml" file and run the tests again

PS C:\Users\aaa\bbb\dio\plugins\web_adapter> flutter test
No tests ran.
No tests were found.

or

PS C:\Users\aaa\bbb\dio\plugins\web_adapter\test> flutter test .\browser_test.dart
Changing current working directory to: C:\Users\aaa\bbb\dio\plugins\web_adapter
No tests ran.
No tests were found.

AlexV525 · 2024-10-19T11:20:48Z

I tried to add the test, but I get the following error

Try to set up the test like the GitHub workflow of this library.

…orBrowser # Conflicts: # plugins/web_adapter/lib/src/adapter.dart # plugins/web_adapter/lib/src/dio_impl.dart

mbfakourii · 2024-10-30T05:57:00Z

Please add tests.

Test added

AlexV525 · 2024-12-16T12:27:23Z

plugins/web_adapter/lib/src/dio_impl.dart

+      RequestOptions(
+        baseUrl: urlPath,
+        data: data,
+        method: 'GET',


Why always GET?

AlexV525 · 2024-12-16T12:28:27Z

plugins/web_adapter/lib/src/dio_impl.dart

+    final completer = Completer<Response>();
+
+    // Set response in Completer
+    completer.complete(response);
+
+    return completer.future;


These are unnecessary.

AlexV525 · 2024-12-16T12:28:54Z

plugins/web_adapter/lib/src/dio_impl.dart

What will the result be after downloaded? Could you demonstrate how it works?

EDIT: Please also add an example somewhere in our examples so everyone can run and see how it works.

feat: add support web download

c429be1

mbfakourii requested a review from a team as a code owner June 2, 2024 14:38

mbfakourii changed the title ~~Add support web download~~ Add support download function in web Jun 2, 2024

fix: code format

7147d04

kuhnroyal reviewed Jun 2, 2024

View reviewed changes

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

fix: add ResponseType.bytes

6e5a96b

tm1000 mentioned this pull request Jun 2, 2024

Error: Resource not accessible by integration clearlyip/code-coverage-report-action#64

Open

AlexV525 requested changes Jun 3, 2024

View reviewed changes

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

AlexV525 marked this pull request as draft June 3, 2024 02:12

fix: change implementation base XMLHttpRequest

4dec223

mbfakourii changed the title ~~Add support download function in web~~ Add support for download function in web Jun 3, 2024

mbfakourii marked this pull request as ready for review June 5, 2024 05:25

AlexV525 reviewed Jun 9, 2024

View reviewed changes

dio/lib/src/options.dart Outdated Show resolved Hide resolved

dio/lib/src/dio/dio_for_browser.dart Outdated Show resolved Hide resolved

dio/lib/src/adapters/browser_adapter.dart Outdated Show resolved Hide resolved

Merge branch 'main' into fix_DioForBrowser

3853fc9

mbfakourii added 3 commits June 18, 2024 14:05

Merge branch 'main' into fix_DioForBrowser

7cf567f

# Conflicts: # dio/lib/src/adapters/browser_adapter.dart # dio/lib/src/dio/dio_for_browser.dart

fix: change the implementation based on the latest changes

0b1fbe6

fix: change the implementation based on the latest changes

77c63b8

AlexV525 reviewed Jun 19, 2024

View reviewed changes

mbfakourii added 4 commits June 22, 2024 14:16

Merge branch 'main' into fix_DioForBrowser

7bc44a1

Merge branch 'main' into fix_DioForBrowser

cf1c52d

fix: improve description

1bbc7f9

fix: remove listenCancelForAsyncTask

9db2305

AlexV525 mentioned this pull request Jul 26, 2024

Is it now possible to use DIO / dio_web_adapter with Web/WASM? #2265

Closed

AlexV525 marked this pull request as draft October 19, 2024 11:21

mbfakourii added 3 commits October 30, 2024 07:36

Merge remote-tracking branch 'refs/remotes/origin/main' into fix_DioF…

5917273

…orBrowser # Conflicts: # plugins/web_adapter/lib/src/adapter.dart # plugins/web_adapter/lib/src/dio_impl.dart

fix: blob with web

d029294

test: add test

9f1f36e

mbfakourii marked this pull request as ready for review October 30, 2024 05:57

mbfakourii requested a review from a team as a code owner October 30, 2024 05:57

AlexV525 reviewed Dec 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `download` function in web #2230

Add support for `download` function in web #2230

mbfakourii commented Jun 2, 2024

kuhnroyal commented Jun 2, 2024

kuhnroyal left a comment

AlexV525 left a comment

mbfakourii commented Jun 3, 2024

github-actions bot commented Jun 4, 2024

AlexV525 left a comment

AlexV525 commented Jun 18, 2024

mbfakourii commented Jun 18, 2024 •

edited

Loading

AlexV525 left a comment

AlexV525 Jun 19, 2024

mbfakourii Jul 8, 2024

AlexV525 Jun 19, 2024

mbfakourii Jul 8, 2024

mbfakourii commented Jul 8, 2024 •

edited

Loading

AlexV525 commented Jul 26, 2024

mbfakourii commented Sep 3, 2024 •

edited

Loading

AlexV525 commented Oct 19, 2024

mbfakourii commented Oct 30, 2024

AlexV525 Dec 16, 2024

AlexV525 Dec 16, 2024

AlexV525 Dec 16, 2024 •

edited

Loading

Add support for download function in web #2230

Are you sure you want to change the base?

Add support for download function in web #2230

Conversation

mbfakourii commented Jun 2, 2024

New Pull Request Checklist

Additional context and info

kuhnroyal commented Jun 2, 2024

kuhnroyal left a comment

Choose a reason for hiding this comment

AlexV525 left a comment

Choose a reason for hiding this comment

mbfakourii commented Jun 3, 2024

github-actions bot commented Jun 4, 2024

Code Coverage Report: Only Changed Files listed

AlexV525 left a comment

Choose a reason for hiding this comment

AlexV525 commented Jun 18, 2024

mbfakourii commented Jun 18, 2024 • edited Loading

AlexV525 left a comment

Choose a reason for hiding this comment

AlexV525 Jun 19, 2024

Choose a reason for hiding this comment

mbfakourii Jul 8, 2024

Choose a reason for hiding this comment

AlexV525 Jun 19, 2024

Choose a reason for hiding this comment

mbfakourii Jul 8, 2024

Choose a reason for hiding this comment

mbfakourii commented Jul 8, 2024 • edited Loading

AlexV525 commented Jul 26, 2024

mbfakourii commented Sep 3, 2024 • edited Loading

AlexV525 commented Oct 19, 2024

mbfakourii commented Oct 30, 2024

AlexV525 Dec 16, 2024

Choose a reason for hiding this comment

AlexV525 Dec 16, 2024

Choose a reason for hiding this comment

AlexV525 Dec 16, 2024 • edited Loading

Choose a reason for hiding this comment

Add support for `download` function in web #2230

Add support for `download` function in web #2230

mbfakourii commented Jun 18, 2024 •

edited

Loading

mbfakourii commented Jul 8, 2024 •

edited

Loading

mbfakourii commented Sep 3, 2024 •

edited

Loading

AlexV525 Dec 16, 2024 •

edited

Loading