fix TableGetColumnSortSpecs accepting invalid negative indices

cfillion · Feb 4, 2024 · 1e7945b · 1e7945b
1 parent dfb2a3b
commit 1e7945b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/api/table.cpp b/api/table.cpp
@@ -306,8 +306,8 @@ See TableNeedSort.)")
   FRAME_GUARD;
 
   const ImGuiTableSortSpecs *specs { ImGui::TableGetSortSpecs() };
-  if(!specs || id >= specs->SpecsCount)
-    return false;
+  if(!specs || id < 0 || id >= specs->SpecsCount)
+    return false; // don't assert: user cannot know how many specs there are
 
   const ImGuiTableColumnSortSpecs &spec { specs->Specs[id] };
   if(API_W(column_user_id)) *API_W(column_user_id) = spec.ColumnUserID;