ENT-12151: Added possibility to configure Mission Portal web server ports

[aleksandrychev]

Ticket: ENT-12151

[nickanderson]

I approve, but there is a suggestion of order change I think you should accept.

[craigcomstock]

yeah, distributed cleanup is the only thing that would have trouble if a feeder uses a different port and there isn't any way to know if THAT feeder over there, from the superhub perspective, has changed it's port or not.

I suppose we would have to include the port number in the information we keep on the superhub about the feeder.

As for the superhub accessing itself, that would need to be adjusted as well.

https://github.com/cfengine/masterfiles/blob/master/templates/federated_reporting/nova_api.py#L99

    def _request(self, method, path, body=None):
        url = "https://{}/api/{}".format(self._hostname, path)

[aleksandrychev]

@craigcomstock I adjusted distributed_cleanup.py please review

[craigcomstock]

I'd say this second commit can be removed.

[craigcomstock]

seems pretty solid. I did the httpd.conf changes manually in the template myself in the case of running a VM so I can have multiple VM Hubs, aka port 8008 for rhel-8, 8016 for ubuntu-16, etc. Worked fine so I know the template portion is correct.

[aleksandrychev]

[aleksandrychev]

@cf-bottom jenkins

[cf-bottom]

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11201/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11201/

[aleksandrychev]

@cf-bottom jenkins

[cf-bottom]

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11219/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11219/

[craigcomstock]

right, looks like upgrade deployment tests fail with policy related to this change right?

52.18.130.203	   error: Promised replacement "    $config["cli_rest_server_url"] = "https://localhost:443/api/";" for pattern "^\s*\$config\["cli_rest_server_url"\]\s*=\s*"https://localhost.*/api/";\s*$" is not properly convergent while editing "/var/cfengine/share/GUI/application/config/config.php" (pattern still matches the end-state replacement string "    $config["cli_rest_server_url"] = "https://localhost:443/api/";", consider use of a negative look ahead)
52.18.130.203	   error: Errors encountered when actuating replace_patterns promise "^\s*\$config\["cli_rest_server_url"\]\s*=\s*"https://localhost.*/api/";\s*$"

[craigcomstock]

looks like the policy might need some fixing for upgrade deployment tests in sequential-tests job.