Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-3866: Added test that set_variable_values_ini does not error when keys are not present in promised section #2141

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nickanderson
Copy link
Member

No description provided.

…not present in promised section

Ticket: CFE-3866
Changelog: None
@nickanderson nickanderson force-pushed the CFE-3866_no-error-when-set_variable_values_ini-section-keys-not-present/master branch from 59a650c to 28d6187 Compare November 11, 2021 19:24
Previously set_variable_values_ini would try to resolve field_edits before first
ensuring that the section of the ini being promised was resolved. This results
in errors when there are no fields to edit. This change uses bundle scoped
classes to guard field_edits from actuating until after the promise ensuring the
section itself exists has been reached, effectively preventing the errors from
being emitted.

Ticket: CFE-3867
Changelog: Commit
section can include characters that are not valid classes are canonified
automatically on definition, but we gotta do that for checking
@nickanderson nickanderson added the WIP Work in Progress label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Development

Successfully merging this pull request may close these issues.

1 participant