Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored vocabularies #487

Closed

Conversation

cofinoa
Copy link
Collaborator

@cofinoa cofinoa commented Apr 25, 2024

@larsbarring, as you have suggested at PR #486 , I have refactored vocabularies.md to actual Markdown, instead HTML, and also I have generated automatically some of the lists.

Jekyll, it's quite limited to manage data and/or strings, and it's needed to create a Jekyll plugin to improve that, but my Ruby skills are also quite limited.

@cofinoa cofinoa requested review from larsbarring and a team April 25, 2024 00:05
Copy link
Contributor

@larsbarring larsbarring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cofinoa Many thanks -- something like this is exactly what I was thinking of. However, I cannot provide any specific input regarding the coding and otherwise changes. THus I leave a detailed review to others.

@JonathanGregory JonathanGregory mentioned this pull request Apr 25, 2024
@larsbarring
Copy link
Contributor

The lists of links will be automatically generated from existing version subdirectories under the ../Data/ directory I think that the workflow will be simplified for publishing a new version of the Standard Name Table, Area Type Table (the versions of the Standardized Regions List is hardcoded?).

Hence pinging @japamment, @efisher008

@JonathanGregory
Copy link
Contributor

Dear Antonio and Lars

Thanks for working on this issue! It's very helpful. I would like to suggest that it makes the history of what's happened easier to follow if we keep to the practice of putting substantial comments in the issue, rather than PRs. That's because the issue is a continuous record of activity, whereas there can be lots of PRs, including comments on documents that aren't arranged serially.

Best wishes

Jonathan

@cofinoa
Copy link
Collaborator Author

cofinoa commented Apr 25, 2024

@larsbarring I will leave this PR on standby. The auto-generated links to ../Data has some pitfalls.

@cofinoa cofinoa closed this Apr 25, 2024
@cofinoa cofinoa deleted the refactor-vocabularies-page branch April 29, 2024 16:00
@cofinoa cofinoa restored the refactor-vocabularies-page branch April 29, 2024 16:00
@cofinoa cofinoa deleted the refactor-vocabularies-page branch June 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants