Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update to Next 13 #490

Merged
merged 8 commits into from
Nov 4, 2023
Merged

build: Update to Next 13 #490

merged 8 commits into from
Nov 4, 2023

Conversation

ruioliveira02
Copy link
Member

No description provided.

@ruioliveira02 ruioliveira02 self-assigned this Aug 23, 2023
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 23, 2023 11:04 — with GitHub Actions Inactive
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 27, 2023 18:38 — with GitHub Actions Inactive
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 27, 2023 18:39 — with GitHub Actions Inactive
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 27, 2023 18:45 — with GitHub Actions Inactive
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 27, 2023 19:07 — with GitHub Actions Inactive
@ruioliveira02 ruioliveira02 temporarily deployed to staging August 27, 2023 19:28 — with GitHub Actions Inactive
@github-actions
Copy link

This pull request is being automatically deployed to Netlify.

✅ Preview: https://deploy-preview-490--seium.netlify.app/

@ruioliveira02 ruioliveira02 marked this pull request as ready for review September 3, 2023 14:49
ruilopesm
ruilopesm reviewed Sep 3, 2023
View reviewed changes
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Does this happen to you too?

@ruioliveira02 ruioliveira02 temporarily deployed to staging September 4, 2023 08:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This pull request is being automatically deployed to Netlify.

✅ Preview: https://deploy-preview-490--seium.netlify.app/

EnzoVieira
EnzoVieira requested changes Oct 22, 2023
View reviewed changes
layout/Attendee/Store/components/Product/index.tsx Outdated
className={enabled ? "opacity-100" : "opacity-50"}
className={`group relative cursor-pointer ${
enabled ? "opacity-100" : "opacity-50"
}`}
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this passHref is no longer needed

https://nextjs.org/docs/pages/api-reference/components/link#if-the-child-is-a-custom-component-that-wraps-an-a-tag

layout/ResetPassword/components/ResetPasswordForm/index.tsx Outdated
@@ -98,13 +98,11 @@ export default function ResetPasswordForm() {
</p>
<div className="w-96">
<Link href="/login" passHref>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

components/Base/index.jsx Outdated
: "text-white hover:bg-primary hover:bg-opacity-50",
"group flex items-center border-b-2 border-tertiary border-opacity-50 px-8 py-8 font-ibold text-xs"
)}
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

components/Base/index.jsx Outdated
<Link
key={item}
href={`${baseHref}/${item}`}
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

components/Dashboard/index.jsx Outdated
@@ -142,8 +142,8 @@ export default function Dashboard(props) {
</a>
))}
</nav>
<Link href="/" passHref>
<a className="px-4 font-iregular text-quinary">Log out 👋</a>
<Link href="/" className="px-4 font-iregular text-quinary" passHref>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

components/Footer/index.tsx Outdated
<Link passHref href="/docs/survival.pdf">
<a className="hover:underline">Survival Guide</a>
<Link
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

components/Navbar/index.jsx Outdated
Comment on lines 73 to 83
passHref
>
{item.name}
</Link>
))}
{isAuthenticated ? null : (
<Link key="login" href="/login" passHref>
<a className="font-iregular text-sm text-white text-opacity-40 hover:text-opacity-100">
Login
</a>
<Link
key="login"
href="/login"
className="font-iregular text-sm text-white text-opacity-40 hover:text-opacity-100"
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

components/Navbar/index.jsx Outdated
{item.name}
</a>
<Link
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

layout/Attendee/Store/components/Product/index.tsx Outdated
className={enabled ? "opacity-100" : "opacity-50"}
className={`group relative cursor-pointer ${
enabled ? "opacity-100" : "opacity-50"
}`}
passHref
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

layout/ResetPassword/components/ResetPasswordForm/index.tsx Outdated
@@ -98,13 +98,11 @@ export default function ResetPasswordForm() {
</p>
<div className="w-96">
<Link href="/login" passHref>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@ruioliveira02 ruioliveira02 temporarily deployed to staging October 26, 2023 09:47 — with GitHub Actions Inactive
EnzoVieira
EnzoVieira previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@EnzoVieira EnzoVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

@netlify Netlify
Copy link

netlify bot commented Nov 4, 2023 •
edited
Loading

✅ Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit 1993f95
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/6546b40692fb7f00082b510e
😎 Deploy Preview https://deploy-preview-490--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MarioRodrigues10
MarioRodrigues10 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ruioliveira02 ruioliveira02 merged commit f8d5cc9 into main Nov 4, 2023
5 checks passed
@ruioliveira02 ruioliveira02 deleted the ro/next-13 branch November 4, 2023 21:16
@MarioRodrigues10 MarioRodrigues10 mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioRodrigues10 MarioRodrigues10 MarioRodrigues10 approved these changes

@EnzoVieira EnzoVieira EnzoVieira left review comments

@tiago-bacelar tiago-bacelar Awaiting requested review from tiago-bacelar

@diogogmatos diogogmatos Awaiting requested review from diogogmatos

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

Assignees

@ruioliveira02 ruioliveira02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruioliveira02 @EnzoVieira @ruilopesm @MarioRodrigues10