Update Hero Design & General Improvements
#17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cesium-hydrogen-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
diogogmatos
requested review from
EnzoVieira,
afonsopimenta,
ruilopesm and
GresosJ
and removed request for
EnzoVieira
ruilopesm
changed the title
diogogmatos
changed the title
Hero Design & General Improvements
ruilopesm
reviewed
Sep 30, 2023
|
|
||
| export default function Team() { | ||
| export default function Equipa() { |
There was a problem hiding this comment.
It is a bit weird to have the naming in portuguese 😅
I think the page should be called team and so the component.
There was a problem hiding this comment.
Agreed, i think it is good having the navbar link in portuguese since the whole website is, but the component and filename (therefor, the url) should stay in english.
|
Closed due to integral project changes both in planning and structure, #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the code for better modularity and focused on reducing the use of repeated code.
Better documented and organized existing code for better readability and easier understanding.
Made some tweaks to the UI.
Update: