Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add news and events section #10

Merged
merged 4 commits into from
Aug 24, 2023
Merged

feat: add news and events section #10

merged 4 commits into from
Aug 24, 2023

Conversation

rafaellseara
Copy link
Contributor

Added news and events section without responsiveness

@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit db6ed1e
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/64e74c29a1d7fc000838bdf4
😎 Deploy Preview https://deploy-preview-10--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@GresosJ GresosJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20230810_202353

For better understanding we could have the selected section highlighted, like when it is hover

prettier.js Outdated Show resolved Hide resolved
Copy link
Member

@afonsopimenta afonsopimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier.js should be renamed back to prettier.config.js since the former does not work. And npm run format should be run again in order to properly reorder the tailwind classes.

Copy link
Member

@afonsopimenta afonsopimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Copy link
Member

@EnzoVieira EnzoVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! 🚀

Your code looks very nice and please keep trying to resolve the prettier problem in your system. I will search for some possible problems that are causing this issue to try helping you

@afonsopimenta
Copy link
Member

afonsopimenta commented Aug 11, 2023

From the research I've done the problem seems to be with the prettier vscode extension not supporting javascript files with require(). The way to fix it is just to disable the "format on save" vscode setting and getting used to the prettier npm package. You can still use the prettier extension but it is not recommended for projects that need plugins added to prettier since those need to be configured through require() or import.

If your project doesn't need prettier plugins like prettier-plugin-tailwindcss you can just use .prettierrc instead of prettier.config.js and the prettier extension should work as expected.

This is still an open issue on the prettier-vscode repo.

I've done some testing on my own computer and the results seem to correspond to the research.

@ruilopesm ruilopesm changed the title Add news and events section feat: add news and events section Aug 24, 2023
@ruilopesm ruilopesm merged commit 056f032 into main Aug 24, 2023
6 checks passed
@ruilopesm ruilopesm deleted the RS/NewsAndEvents branch August 24, 2023 12:28
@ruilopesm ruilopesm added the enhancement New feature or request label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants