refactor: improve calendar performance and style #518
Conversation
… improve hours column styling
Do you actually follow the organization? You can try unfollowing and following the organization that has the activity again. I believe the seeds that makes generated users follow organizations is a bit broken, because the button shows up as following when the organization has 0 followers. Also, does the same activity show up in any other view? For me it seems to be working. |
|
@nunom27 I can see activities properly while on a desktop dimensions. After resizing the screen to mobile, activities do not show anymore. I guess we'll have to wait until someone try to reproduce it 😅 |
|
Can't reproduce it on my side @ruilopesm . 🤔 2024-09-01.08-29-40.mp4 |
|
It works on my side, but looks a little bit odd on my side. |
|
@MarioRodrigues10 That happened due to the activity starting at 23:35, so it only takes 5 rows until midnight (each row represents 5 minutes intervals). I can try, however, to put the title right in front of the time on those cases, so that it doesn't look as odd. |
|
It's properly working for me now. I might have tested it wrongly 😅 |
| <%= if Enum.count(get_date_activities(@activities, @date)) > 2 do %> | ||
| <li class="text-zinc-500 hover:text-primary-600"> | ||
| <button type="button" phx-click="show-more" phx-value-date={@date}> | ||
| +<%= Enum.count(get_date_activities(@activities, @date)) - 2 %> more | ||
| </button> | ||
| </li> | ||
| <% end %> |
There was a problem hiding this comment.
There's a new short syntax for cases like this (same for other places, if you prefer it like so)
<li :if={Enum.count(get_date_activities(@activities, @date)) > 2} class="...">
Also, would you consider this calculation heavy? If so, prefer to assign it before rendering the template, by calculating it only once (you are using it at least twice).
#398