Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CVs #455

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: add CVs #455

wants to merge 2 commits into from

Conversation

MarioRodrigues10
Copy link
Member

No description provided.

@MarioRodrigues10 MarioRodrigues10 self-assigned this Feb 17, 2024
@MarioRodrigues10 MarioRodrigues10 added the enhancement New feature or improvements label Feb 17, 2024
@MarioRodrigues10 MarioRodrigues10 added this to the 1.0.0 milestone Feb 17, 2024
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the test CV to something resembling a CV and not a project statement please 🙏

@@ -5,7 +5,7 @@ defmodule Atomic.Uploader do
"""

@versions [:original, :medium, :thumb]
@extensions_whitelist ~w(.svg .jpg .jpeg .png)
@extensions_whitelist ~w(.svg .jpg .jpeg .png .pdf .docx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should handle CV in this module. It defines functions to apply image transformations which do not make sense in a PDF or DOCX file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i break this logic in this PR, or should i refactor the code in another?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one

@MarioRodrigues10 MarioRodrigues10 modified the milestones: 1.0.0, After 1.0.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvements
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants