Fixed unbound vars and implemented some bash good practices #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| OUTPUT= | ||
|
|
||
| while getopts "hvza:c:e:o:r:u:p:n:" OPTION | ||
| while getopts ":hvza:c:e:o:r:u:p:n:" OPTION |
There was a problem hiding this comment.
The reason for this change and the one on line 99 is this (from the getopts manpage): If an option character not contained in the optstring operand is found where an option character is expected, the shell variable specified by name shall be set to the ('?') character. In this case, if the first character in optstring is a (':'), the shell variable OPTARG shall be set to the option character found, but no output shall be written to standard error; otherwise, the shell variable OPTARG shall be unset and a diagnostic message shall be written to standard error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationalle for changing the first 2 lines can be found here: http://kvz.io/blog/2013/11/21/bash-best-practices/