TAT-142 Add logo to site #25
Conversation
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
…t attack version as a store value
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
|
Since this PR contains some odds and ends, I'm going to add some notes here with feedback across the entire site (even for things that were not changed in this PR). I also added a commit to tweak some of the template language.
I think you should hide the GUID and just focus on ID and name, like "M1053 - Data Backup".
@mikecarenzo just implemented support for ATT&CK citations in TIE. Can you sync up with him -- is it easy to port that code over here?
Can you enable markdown rendering for the detections text?
Can you set a max width (or column limit) for this text? In MapEx it's a
Are we sure the component logic is implemented correctly? I tried setting them all to high, low, random, etc. and the top 10 list seems like it stays the same. Changing the controls definitely affects the results, but components doesn't seem to. It also seems like it doesn't match the original calculator. Do we have unit tests for the calculator logic? Have we tested this against the existing calculator or even going all the way back to the methodology and writing new test cases from scratch? |
|
Can you also set the package version to 2.0.0? |
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
… improve 508 compliance and mobile view
…sing spreadsheet (from updating to latest ATT&CK)
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
|
This PR has been published to https://topattacktechniques.z13.web.core.windows.net/TAT-142-create-logo/ |
allisonrobbins
merged commit 556853b
into
TAT-121-single-page-app-conversion
Add logo to homepage, nav bar, and footer
Also cleaned up some 508 technical debt: