refactor initLineCoverage

cenfun · Aug 1, 2024 · d656c24 · d656c24
1 parent b400514
commit d656c24
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/lib/converter/converter.js b/lib/converter/converter.js
@@ -141,9 +141,8 @@ const handleLinesCoverage = (bytes, locator, ignoredRanges) => {
             return;
         }
 
-        lineItem.coveredCount = 1;
-        lineItem.uncoveredEntire = null;
-        lineItem.uncoveredPieces = [];
+        Util.initLineCoverage(lineItem);
+
         lineMap.set(line, lineItem);
     });
 

diff --git a/lib/platform/share.js b/lib/platform/share.js
@@ -338,6 +338,12 @@ const Util = {
         return lines;
     },
 
+    initLineCoverage: (lineItem) => {
+        lineItem.coveredCount = 1;
+        lineItem.uncoveredEntire = null;
+        lineItem.uncoveredPieces = [];
+    },
+
     updateLinesCoverage: (lines, count, lineMap) => {
         lines.forEach((it) => {
             const lineItem = lineMap.get(it.line);

diff --git a/packages/app/src/utils/coverage.js b/packages/app/src/utils/coverage.js
@@ -42,9 +42,8 @@ class CoverageParser {
             }
             // 1-base
             const line = lineItem.line + 1;
-            lineItem.coveredCount = 1;
-            lineItem.uncoveredEntire = null;
-            lineItem.uncoveredPieces = [];
+
+            Util.initLineCoverage(lineItem);
 
             // need set `ignore` line, and will add ignoredCount
             lineItem.ignored = this.isLineIgnored(lineItem, formattedIgnores);