Add a ".NETCoreApp3.0" dependency to the .nuspec files #2894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2796
Summary:
.NETCoreApp3.0
dependency to the .nuspec files.Changes:
<group targetFramework=".NETCoreApp3.0">
toCefSharp.OffScreen.nuspec
,CefSharp.WinForms.nuspec
andCefSharp.Wpf.nuspec
.This ensures the transitive dependencies (CefSharp.Common) will be resolved in .NET Core 3.0 projects, when adding only
CefSharp.WinForms
,CefSharp.WPF
orCefSharp.OffScreen
via<PackageReference>
.How Has This Been Tested?
Tested by running
build.ps1
, and then using the built.nupkg
packages (via local NuGet package source) in theCefSharp.MinimalExample.NetCore.*
projects (see cefsharp/CefSharp.MinimalExample#57) and removing the package reference toCefSharp.Common
.Screenshots (if appropriate):
Types of changes
Checklist: