Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ".NETCoreApp3.0" dependency to the .nuspec files #2894

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

kpreisser
Copy link
Contributor

@kpreisser kpreisser commented Sep 6, 2019

Issue #2796

Summary:

  • Added a .NETCoreApp3.0 dependency to the .nuspec files.

Changes:

  • Added <group targetFramework=".NETCoreApp3.0"> to CefSharp.OffScreen.nuspec, CefSharp.WinForms.nuspec and CefSharp.Wpf.nuspec.
    This ensures the transitive dependencies (CefSharp.Common) will be resolved in .NET Core 3.0 projects, when adding only CefSharp.WinForms, CefSharp.WPF or CefSharp.OffScreen via <PackageReference>.

How Has This Been Tested?

Tested by running build.ps1, and then using the built .nupkg packages (via local NuGet package source) in the CefSharp.MinimalExample.NetCore.* projects (see cefsharp/CefSharp.MinimalExample#57) and removing the package reference to CefSharp.Common.

Screenshots (if appropriate):

grafik

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

This ensures the transitive dependencies (CefSharp.Common) are correctly resolved in .NET Core 3.0 projects.

Contributes to cefsharp#2796
@AppVeyorBot
Copy link

@amaitland amaitland added this to the 77.0.0 milestone Sep 6, 2019
@amaitland amaitland merged commit ce70212 into cefsharp:master Sep 6, 2019
@kpreisser kpreisser deleted the nuspecNetCoreDependency branch September 7, 2019 08:54
amaitland pushed a commit that referenced this pull request Sep 8, 2019
This ensures the transitive dependencies (CefSharp.Common) are correctly resolved in .NET Core 3.0 projects.

Contributes to #2796
@amaitland amaitland modified the milestones: 77.0.0, 75.1.142 Sep 8, 2019
@amaitland
Copy link
Member

Manually merged into cefsharp/75 in 9d6e5de

Milestone updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants