Improve logging of command output.

cedadev · Sep 11, 2024 · f1d0101 · f1d0101
1 parent e3caad6
commit f1d0101
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/jasmin_slurm_sync/user.py b/jasmin_slurm_sync/user.py
@@ -75,8 +75,14 @@ def add_user_to_account(self, account: str) -> None:
                     account,
                 )
             else:
-                utils.run_ratelimited(args, capture_output=False, check=True)
+                cmd_output = utils.run_ratelimited(
+                    args, capture_output=True, check=True
+                )
                 logger.info("Added user %s to account %s", self.username, account)
+                if cmd_output.stderr:
+                    logger.error(cmd_output.stderr)
+                if cmd_output.stdout:
+                    logger.debug(cmd_output.stdout)
         else:
             logger.info(
                 "Not adding %s to %s, because account is not managed.",
@@ -102,8 +108,14 @@ def remove_user_from_account(self, account: str) -> None:
                     account,
                 )
             else:
-                utils.run_ratelimited(args, capture_output=False, check=True)
+                cmd_output = utils.run_ratelimited(
+                    args, capture_output=True, check=True
+                )
                 logger.info("Removed user %s from account %s", self.username, account)
+                if cmd_output.stderr:
+                    logger.error(cmd_output.stderr)
+                if cmd_output.stdout:
+                    logger.debug(cmd_output.stdout)
         else:
             logger.debug(
                 "Not removing %s from %s, because account is not managed.",