Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to optionally return node depth #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

williamgilpin
Copy link

Hello, thanks very much for this fantastic package. For an application I'm working on, I need to be able to get the node depth when I look up a string in the suffix tree. This is usually smaller than the depth property, since it treats multi-character nodes as a single hop as we move down the tree.

I implemented this using optional arguments, to avoid breaking the existing API. It simply consists of adding a counter to the find_path function, which increments whenever node is updated to point to a child of the current node.

It might be possible to instead implement this as an attribute of each node, which is set whenever the tree is first constructed, but I don't know enough about McCreight's Algorithm to implement this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant