Added ability to optionally return node depth #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks very much for this fantastic package. For an application I'm working on, I need to be able to get the node depth when I look up a string in the suffix tree. This is usually smaller than the depth property, since it treats multi-character nodes as a single hop as we move down the tree.
I implemented this using optional arguments, to avoid breaking the existing API. It simply consists of adding a counter to the
find_path
function, which increments whenever node is updated to point to a child of the current node.It might be possible to instead implement this as an attribute of each node, which is set whenever the tree is first constructed, but I don't know enough about McCreight's Algorithm to implement this myself.