fix(dap-ui): add colors for *NC hlgroups of UI controls #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgoudham
reviewed
Oct 23, 2024
`nvim-dap-ui` has highlight groups for all its buttons: `DapUIPlayPause`, `DapUIStepOver`, etc. But it also has `*NC` versions of those highlights. I assume NC stands for non-current or "no cursor". `nvim-dap-ui` defaults to linking those to their non-`*NC` versions but I assume it happens too early and Catppuccin does not pick that up. This PR simply duplicates the highlight groups to include `*NC` versions. See https://github.com/rcarriga/nvim-dap-ui/blob/ffa89839f97bad360e78428d5c740fdad9a0ff02/lua/dapui/config/highlights.lua#L75-L96
fnune
force-pushed
the
fnune/fix-dap-ui-nc-hls
branch
from
b2b1518
to
29e42eb
Compare
sgoudham
approved these changes
Oct 24, 2024
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvim-dap-uihas highlight groups for all its buttons:DapUIPlayPause,DapUIStepOver, etc. But it also has*NCversions of those highlights. I assume NC stands for non-current or "no cursor".nvim-dap-uidefaults to linking those to their non-*NCversions but I assume it happens too early and Catppuccin does not pick that up. This PR simply duplicates the highlight groups to include*NCversions.See https://github.com/rcarriga/nvim-dap-ui/blob/ffa89839f97bad360e78428d5c740fdad9a0ff02/lua/dapui/config/highlights.lua#L75-L96
Before
After