Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treesitter_context): underline content if transparent_background is true #519

Merged

Conversation

joshmedeski
Copy link
Contributor

Updates the Treesitter Context plugin to use a transparent background if transparent_background was set.

@nullchilly
Copy link
Contributor

nullchilly commented Jun 22, 2023

treesitter_context integration is not enabled by default and thus support transparent background out of the box

The reason the integration still exists is to make it more distinguishable for #445

I think we should add a note for what the integration really do.

@joshmedeski joshmedeski changed the title feat: add support for transparent background with Tresitter Context i… Treesitter Context transparent support Jun 22, 2023
@joshmedeski
Copy link
Contributor Author

Okay, I won't enable the integration so I can get transparency.

Do you think I should update this PR to add a code comment mentioning that enabling this integration makes it distinguishable when transparency is enabled? That is unclear when looking at the source-code. It just appears to be a missing feature.

If not, feel free to just close the PR.

@nullchilly
Copy link
Contributor

nullchilly commented Jun 22, 2023

I think we can define hi TreesitterContextBottom gui=underline when transparency is enabled, I think this would be a saner default.

image

@nullchilly
Copy link
Contributor

nullchilly commented Jun 22, 2023

LGTM! @mrtnvgr @sxyazi

Copy link
Collaborator

@mrtnvgr mrtnvgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrtnvgr mrtnvgr changed the title Treesitter Context transparent support fix(treesitter_context): underline content if background is transparent Jun 23, 2023
@mrtnvgr mrtnvgr changed the title fix(treesitter_context): underline content if background is transparent fix(treesitter_context): underline content if transparent_background is true Jun 23, 2023
@nullchilly nullchilly merged commit 6ecc158 into catppuccin:main Jun 24, 2023
9 checks passed
@joshmedeski joshmedeski deleted the treesitter-context-transparency branch June 24, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants