Skip to content

Commit

Permalink
Fix Failing Dailies (#340)
Browse files Browse the repository at this point in the history
* passed along secrets to update-testing-data

* added secrets to workflow_call section of update-testing-data

* fixed indentation

* added run-tests secrets

* added secrets to deploy_pr_tests

* updated changelog
  • Loading branch information
pauladkisson authored Jun 4, 2024
1 parent 967aaca commit 29c3491
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/dailies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,16 @@ on:
jobs:
update-testing-data:
uses: ./.github/workflows/update-testing-data.yml
secrets:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}

run-tests:
needs: update-testing-data
uses: ./.github/workflows/run-tests.yml
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

notify:
runs-on: ubuntu-latest
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/deploy_pr_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,16 @@ concurrency:
jobs:
update-testing-data:
uses: ./.github/workflows/update-testing-data.yml
secrets:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
S3_GIN_BUCKET: ${{ secrets.S3_GIN_BUCKET }}

run-tests:
needs: update-testing-data
uses: ./.github/workflows/run-tests.yml
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

dev-tests:
needs: update-testing-data
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Full Tests
on:
workflow_dispatch:
workflow_call:
secrets:
CODECOV_TOKEN:
required: true

jobs:
run:
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/update-testing-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ name: update-testing-data
on:
workflow_dispatch:
workflow_call:
secrets:
AWS_ACCESS_KEY_ID:
required: true
AWS_SECRET_ACCESS_KEY:
required: true
S3_GIN_BUCKET:
required: true

jobs:
run:
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Remove unnecessary `scipy` import error handling: [#315](https://github.com/catalystneuro/roiextractors/pull/315)
* Fixed the typing returned by the `InscopixImagingExtractor.get_dtype` method: [#326](https://github.com/catalystneuro/roiextractors/pull/326)
* Detect Changelog Updates was moved to its own dedicated workflow to avoid daily testing failures: [#336](https://github.com/catalystneuro/roiextractors/pull/336)
* Fixed the Update Testing Data Workflow by unpinning the version of awscli: [#339](https://github.com/catalystneuro/roiextractors/pull/339)
* Fixed the Daily testing workflows by passing along the appropriate secrets: [#340](https://github.com/catalystneuro/roiextractors/pull/340)

### Improvements

Expand Down

0 comments on commit 29c3491

Please sign in to comment.