Add trials metadata #999
Draft
Add trials metadata #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…0. I think they should be allowed to be 0-length
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 91.44% 91.37% -0.08%
==========================================
Files 127 127
Lines 7525 7556 +31
==========================================
+ Hits 6881 6904 +23
- Misses 644 652 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
h-mayorquin
reviewed
Aug 13, 2024
| TimeIntervals=dict( | ||
| trials=dict( | ||
| columns=dict( | ||
| start_time=dict(description="start time of the trial"), |
There was a problem hiding this comment.
Isn't this overwritten by the schema by default? the description of start_time and stop_time?
| "type": "string" | ||
| } | ||
| }, | ||
| "required": [ |
There was a problem hiding this comment.
Shouldn't description be required as well?]
from pynwb.testing.mock.file import mock_NWBFile
nwbfile = mock_NWBFile()
nwbfile.add_trial_column(name='correct')Throws an error.
| columns=dict( | ||
| start_time=dict(description="start time of the trial"), | ||
| stop_time=dict(description="stop time of the trial"), | ||
| correct=dict(description="correct or not"), |
There was a problem hiding this comment.
I was expecting that you had to pass the name inside the dictionary as well from reading the schema, but here, the name here is only passed as the dictionary key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #997