Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement IV] Add roi response series #19

Merged
merged 67 commits into from
Aug 28, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

OK turns out I do need to override RoiResponseSeries after all, not due to schema per se but due to PyNWB API defining custom checks on the dynamic table region target

@CodyCBakerPhD CodyCBakerPhD self-assigned this Jun 27, 2024
@CodyCBakerPhD CodyCBakerPhD changed the title [Enhancement V] Add roi response series [Enhancement IV] Add roi response series Jul 12, 2024
Base automatically changed from swap_to_um to main July 19, 2024 14:10
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 27, 2024 16:43
@CodyCBakerPhD
Copy link
Member Author

@alessandratrapani All tests passing

Might be simpler to get this in before #22

Copy link
Collaborator

@alessandratrapani alessandratrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodyCBakerPhD CodyCBakerPhD merged commit 6f5ceae into main Aug 28, 2024
32 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the add_roi_response_series branch August 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants