Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Lohani22 conversion pipeline #23

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented May 28, 2024

@alessandratrapani alessandratrapani self-assigned this May 28, 2024
@alessandratrapani
Copy link
Collaborator Author

1p-only stub here

@alessandratrapani alessandratrapani marked this pull request as ready for review June 13, 2024 13:22
@weiglszonja
Copy link
Collaborator

Looks good, I just noticed that the TTL table is not ordered by timestamp, but by ttl_type:
Screenshot 2024-06-14 at 12 19 48 (2)
I'm not sure how big issue is this, in Neurosift we can reorder the columns by timestamp. I'll let you decide

@alessandratrapani
Copy link
Collaborator Author

alessandratrapani commented Jun 14, 2024

Looks good, I just noticed that the TTL table is not ordered by timestamp, but by ttl_type: Screenshot 2024-06-14 at 12 19 48 (2) I'm not sure how big issue is this, in Neurosift we can reorder the columns by timestamp. I'll let you decide

I will see if I can re-order the table after creating it, and to add also the check_ragged = False in #28

@alessandratrapani alessandratrapani merged commit c5e4816 into main Jun 14, 2024
@alessandratrapani alessandratrapani deleted the improve_lohani22_conversion branch July 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants