Bump to Java 11 #177
Merged
Bump to Java 11 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds reasonable. I don't know why its on the 1.8 currently. |
kyeotic
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately bumping the kotlin version didn't resolve #171 for us. We've been developing against a temporary private fork to stay unblocked (read: a copy/pasted monstrosity), but I'd like to get it cleaned up.
I'm hoping that means that the JVM version mismatch is the issue, since we're on Java 21. Since this is the same JVM version used in Misk, I figure it's ok to bump to. Honestly though, this is a shot in the dark. I've got no idea what's causing these issues
I've made a few attempts to downgrade the JVM version on my end for testing purposes, but it ends up in dependency hell really quickly so this seemed like the easiest next step.
Let me know if there's a specific reason tempest uses 1.8