Migrate to libs.versions.toml #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkerford
approved these changes
Jan 15, 2024
staktrace
approved these changes
Jan 15, 2024
| @@ -56,7 +56,7 @@ subprojects { | |||
|
|
|||
| dependencies { | |||
| // add("api", project(":tempest-bom")) | |||
| add("api", platform(Dependencies.nettyBom)) | |||
| add("api", platform(libs.nettyBom)) | |||
There was a problem hiding this comment.
Hmm, I'm kind of surprised this works. In subprojects blocks you usually need to reference libs via rootProject.libs due to a gradle bug (gradle/gradle#16634). Are you able to confirm this block is actually getting run?
There was a problem hiding this comment.
Hm, it must be - CI is passing and this would be a build-time error otherwise. Odd, not sure why it didn't work on other repos...
There was a problem hiding this comment.
Seems like it works inside the plugins.withType block but not outside. Woo gradle!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.