Remove empty launch args default_value #622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found in foxy and newer distros that crashes the ROS 2 launch system when an argument with
default_value=''
is not overwritten. For some reason the empty string is internally converted toNone
, which raises the following errorSimilar problems can be found introlab/rtabmap_ros#725, LORD-MicroStrain/ntrip_client#16 and microsoft/Azure_Kinect_ROS_Driver#246
The easiest solution is to replace the empty string with a non-empty string. When an invalid spawn-point is passed, the node issues the following warning and then informs that a random spawn point was chosen
If a spawn point is specified in the object description, the system issues the warnings
After this messages, the launch system proceeds normally
This PR solves the problem described in #603, even without explicit goal of Carla 0.9.13 support. I believe that it is highly likely that people trying to run the newest Carla version are also running the newest version of ROS 2, thus facing the error described here. Personally, I was able to run ros bridge with Carla 0.9.13 smoothly after this fix.
This change is