Fix race condition bug deleting categories #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move total word count reduction before category deletion - Ensure accurate word count maintenance during category removal
- Reduce tested Ruby versions to 2.7 and head
- Update classifier gem from version 1.4.1 to 1.4.2 in Gemfile.lock
- Remove test for nonexistent category removal - Rename and update test for category removal - Add mutex_m requirement in test helper
- Add mutex_m gem to Gemfile and gemspec - Update fast-stemmer dependency version in gemspec - Remove explicit require of mutex_m in test_helper.rb
- Loosen fast-stemmer version constraint to ~> 1.0 - Add mutex_m dependency with version ~> 0.2
cardmagic
referenced
this pull request
Jul 31, 2024
Add remove_category functionality to Bayes classifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Thank you @dpetruha for catching this bug!
These changes primarily focus on updating the Ruby gem version, modifying the CI workflow, and improving the Bayesian classifier functionality. The main modifications include:
remove_categorymethod in the Bayesian classifier.remove_categoryfunctionality.Reason for Changes
The changes aim to update the gem's compatibility, improve its version tracking, and enhance the robustness of the Bayesian classifier's category removal feature.
Detailed Description
CI Workflow Update - The
.github/workflows/ruby.ymlfile has been modified to test fewer Ruby versions, now only including '2.7' and 'head'. This change likely aims to focus testing on the oldest supported version and the latest development version.Gem Version Update - The gem version has been incremented from 1.4.1 to 1.4.2 in the
classifier.gemspecfile. This indicates a minor update or bug fix release.Bayesian Classifier Improvement - The
remove_categorymethod inlib/classifier/bayes.rbhas been modified to update the@total_wordscount before deleting the category data. This ensures that the total word count is accurately maintained even when categories are removed.New Tests - Three new tests have been added to
test/bayes/bayesian_test.rbto verify the correct functionality of theremove_categorymethod: