Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!feat: add authentication support #42

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

!feat: add authentication support #42

wants to merge 11 commits into from

Conversation

sbckr
Copy link
Member

@sbckr sbckr commented Jun 4, 2024

No description provided.

@sbckr sbckr requested a review from a team as a code owner June 4, 2024 11:27
sbckr and others added 2 commits June 5, 2024 08:10
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Jared Weinfurtner <[email protected]>
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 83.54430% with 26 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (4c5b931) to head (8b8d935).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
- Coverage     83.32%   81.35%   -1.97%     
+ Complexity      388      387       -1     
============================================
  Files            69       69              
  Lines          1463     1502      +39     
  Branches         75       80       +5     
============================================
+ Hits           1219     1222       +3     
- Misses          193      223      +30     
- Partials         51       57       +6     
Files Coverage Δ
...amphora/command/AmphoraClientCliCommandRunner.java 87.23% <100.00%> (ø)
...t/castor/command/CastorClientCliCommandRunner.java 80.00% <100.00%> (-0.56%) ⬇️
...meral/command/EphemeralClientCliCommandRunner.java 84.00% <100.00%> (ø)
.../main/java/io/carbynestack/cli/login/VcpToken.java 100.00% <100.00%> (ø)
...n/java/io/carbynestack/cli/login/LoginCommand.java 89.74% <91.17%> (+4.44%) ⬆️
...rbynestack/cli/configuration/VcpConfiguration.java 91.89% <92.72%> (-2.85%) ⬇️
...in/OAuth2AuthenticationCodeCallbackHttpServer.java 80.00% <81.25%> (-6.28%) ⬇️
.../java/io/carbynestack/cli/login/VcpTokenStore.java 67.30% <51.85%> (-27.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5b931...8b8d935. Read the comment docs.

Signed-off-by: Jared Weinfurtner <[email protected]>
Signed-off-by: Jared Weinfurtner <[email protected]>
Signed-off-by: Jared Weinfurtner <[email protected]>
@sbckr
Copy link
Member Author

sbckr commented Jun 28, 2024

@jaredweinfurtner @benjaminhettwer
Code looks good but can one of you please update the License Headers of all files updated (year: 202x-2024)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants