Fix empty reservation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Signed-off-by: Sebastian Becker <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
============================================
+ Coverage 85.45% 85.47% +0.02%
- Complexity 335 336 +1
============================================
Files 61 61
Lines 1210 1212 +2
Branches 79 80 +1
============================================
+ Hits 1034 1036 +2
Misses 142 142
Partials 34 34
Continue to review full report at Codecov.
|
strieflin
requested changes
Dec 13, 2021
...ice/src/test/java/io/carbynestack/castor/service/download/CreateReservationSupplierTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sebastian Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
Lazy loading is not addressed as implementation will be heavily adapted when #10 is addressed