-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup description for secure communication channels #113
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: benjaminhettwer <[email protected]>
Signed-off-by: benjaminhettwer <[email protected]>
…estack.github.io into secure-comm-channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please add yourself to the NOTICE.md
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see individual comment
@@ -112,12 +112,53 @@ clusters using the kind tool as described in the | |||
|
|||
before you proceed. | |||
|
|||
<!-- markdownlint-disable MD013 --> | |||
1. Configure TLS to enable secure communication to, and between the VCPs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be interpreted as this step could be skipped if TLS ist not desired (like in case of development). However this would break the next step (launching VCPs) as it requires the environment variable PROTOCOL
to be defined to work properly
Signed-off-by: benjaminhettwer <[email protected]>
Signed-off-by: benjaminhettwer <[email protected]>
No description provided.