Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup description for secure communication channels #113

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

benjaminhettwer
Copy link
Contributor

No description provided.

@benjaminhettwer benjaminhettwer requested a review from a team as a code owner August 21, 2024 09:48
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add yourself to the NOTICE.md file

Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see individual comment

@@ -112,12 +112,53 @@ clusters using the kind tool as described in the

before you proceed.

<!-- markdownlint-disable MD013 -->
1. Configure TLS to enable secure communication to, and between the VCPs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be interpreted as this step could be skipped if TLS ist not desired (like in case of development). However this would break the next step (launching VCPs) as it requires the environment variable PROTOCOL to be defined to work properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants