Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typesense #1029

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add typesense #1029

wants to merge 6 commits into from

Conversation

vadolasi
Copy link

@vadolasi vadolasi commented Nov 30, 2023

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please make sure the build runs fine. Also, please check the boxes in the PR template.

public/v4/apps/typesense.yml Outdated Show resolved Hide resolved
@vadolasi
Copy link
Author

vadolasi commented Mar 7, 2024

please review this pr @githubsaturn

@githubsaturn
Copy link
Collaborator

Apologies for the late response. But there are still a few issues:

  • it looks like the build is still failing.
  • Also, you have checked in package-lock.json, please remove this.
  • Last, it looks like this PR includes 2 separate apps. Suggest separating them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants